Enhance user guidance in unverified command channel#163
Merged
dimoschi merged 3 commits intohackthebox:mainfrom Mar 24, 2026
Merged
Enhance user guidance in unverified command channel#163dimoschi merged 3 commits intohackthebox:mainfrom
dimoschi merged 3 commits intohackthebox:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 58.91% 62.07% +3.15%
==========================================
Files 50 50
Lines 2865 2937 +72
==========================================
+ Hits 1688 1823 +135
+ Misses 1177 1114 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dimoschi
reviewed
Dec 19, 2025
src/cmds/automation/auto_verify.py
Outdated
Contributor
There was a problem hiding this comment.
The cog is disabled, should that be enabled?
Collaborator
Author
There was a problem hiding this comment.
Did not realize that; i was just wanting to hook into the on_message event and this made sense given the cogs pre-existing function
Contributor
There was a problem hiding this comment.
I'd recommend to:
- Uncomment
bot.add_cog(MessageHandler(bot))in thesetup()function - Optionally clean up the unused
process_reverificationcode (since it just raises an error and creates noise in logs)
- Fix "In-order" typo to "In order" in welcome message - Add test coverage for on_message welcome feature in auto_verify - Fix broken assertion in test_ban.py (called_once_with -> assert_called_once_with)
dimoschi
approved these changes
Jan 1, 2026
- Move hardcoded channel IDs to Channels config (UNVERIFIED_BOT_COMMANDS, HOW_TO_VERIFY) - Add return after welcome reply to avoid falling through to dead reverification - Remove unused process_reverification and VerificationError - Uncomment bot.add_cog in setup() so the cog actually loads - Update tests to reference settings instead of hardcoded IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply.Proposed changes
Describe your changes here and explain why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.
Checklist
Put an
xin the boxes that apply.doc.
Additional context
Add any other context or screenshots here.